-
Notifications
You must be signed in to change notification settings - Fork 212
Added some fault-tolerance to the build queue #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just noticed the add_crate_to_queue(&conn, &krate.name, &krate.version, priority).ok();
debug!("{}-{} added into build queue", krate.name, krate.version); hidden in there, maybe this should be changed to match add_crate_to_queue(&conn, &krate.name, &krate.version, priority) {
Ok(_) => debug!("{}-{} added into build queue", krate.name, krate.version),
Err(err) => error!("failed adding {}-{} into build queue: {}", krate.name, krate.version, err),
} |
I realized that we could also add a prometheus hook for this, if it's something we think is important enough |
I don't this is necessary, we already track the number of crates queued and we can look at the logs or /releases/queue if we want to know the exact crates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for working on this! Do you have any ideas on how to test this? I thought maybe we could delete the crate_priorities
table in the test so that getting the connection and fetching the index succeed, but adding the crate fails.
Why did you change the permissions of the docker entrypoint? |
Fixed, something with Windows messed up |
Thanks for working on this! |
Closes #628
Stops losing crates that are being added to the build queue when a crash occurs. Attempted to make
add_crate_to_queue
batched, but couldn't figure out how to with the current db driver